fix(deps): bump fast-xml-parser to v5.9.3 (clears XMLBuilder injection advisory)#114
Merged
PAMulligan merged 1 commit intoJul 1, 2026
Conversation
…on advisory Corrects issue #108, whose premise was inaccurate: 4.5.3 patches none of the advisories affecting the pinned range, and the lockfile already resolved ^4.5.1 to 4.5.6 (covering the in-range fixes). The one remaining open alert, GHSA-gh4j-gqv2-49f6 / CVE-2026-41650 (XMLBuilder comment & CDATA injection), is patched only in 5.7.0 with no 4.x backport -- the v4 line is EOL for security fixes -- so clearing it requires a major bump, not the in-range refresh the issue assumed. - packages/pipeline: fast-xml-parser ^4.5.1 -> ^5.9.3 (resolves 4.5.6 -> 5.9.3) - The pipeline uses XMLParser only (src/indesign/xml.ts); the vulnerable XMLBuilder API is never called, so real-world exposure was already nil. v5's XMLParser accepts the same options, so no code changes were needed. Verified: pnpm typecheck, 133/133 vitest tests, and tsc build all pass; the React generator snapshot is byte-identical (no behavioural change). Closes #108 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #108 — but corrects its premise. During implementation the framed fix turned out to be wrong, so this PR does the actual fix.
Why "bump to 4.5.3" was a no-op
^4) fixes land in 4.5.4 / 4.5.5; 4.5.3 clears none of the six advisories that affected 4.5.1.^4.5.1→ 4.5.6, which already covered every in-range fix (including the critical DOCTYPE regex-injection one). So 4.5.3 would have been a downgrade.So resolving the advisory requires a major 4 → 5 bump, not the "non-breaking refresh" the issue assumed.
Risk note
The vulnerable API is
XMLBuilder, which this codebase never uses —packages/pipeline/src/indesign/xml.tsimportsXMLParseronly (read-only IDML parsing). Real-world exposure was already nil; this bump also future-proofs off the dead v4 line.What changed
packages/pipeline:fast-xml-parser^4.5.1→^5.9.3(lock resolves 4.5.6 → 5.9.3).XMLParseraccepts the identical option set, soxml.tsis untouched.Verification
pnpm --filter @aurelius/pipeline typecheck— clean.pnpm --filter @aurelius/pipeline test— 133/133 pass (17 files); the React generator snapshot is byte-identical, so parsing behaviour is unchanged.pnpm --filter @aurelius/pipeline build— clean declaration emit.@aurelius/pipelinewith no API change, so it is not breaking for consumers of the package.Note on the mutation gate
Stryker targets
packages/pipelinebut runs nightly / on-demand only — never on PRs. It mutates first-party source (unaffected by a dependency swap); happy to triggerworkflow_dispatchonmutation.ymlafter merge if you want the score refreshed.🤖 Generated with Claude Code